Skip to content

Conversation

manudev0004
Copy link
Contributor

This PR includes all the 11 finalize web components with consistent props, states, methods. To view the demo of all component

  1. Navigate to packages/components/
  2. Run:
    npm run build
    npm start/ npm run start

Open http://localhost:3333 in your browser if not auto redirected. There is global.css in root src/ to handle shared styles. All components include JSDoc comments

@egekorkan
Copy link
Member

My feedback based on the demo:

  • The title "Wot-Components" should be "WoT UI Components"
  • All parameters to the components: if it is camelCase or hyphen, they should be aligned, at least in the documentation
  • Calendar:
    • What is the output string? It should be in the documentation that it is ISO. It would be better if that can be changed (unix, iso etc.) with a parameter.
    • The calendar icon should be added. Currently, there is a gray box, whose usage is not clear.
    • The localization should be possible the parametrize. DD/MM/YYYY and MM/DD/YYYY should be possible at least.
  • Notification: Behavior difference between this and event should be explained. Notifications start coming (when there is a change) as soon as the UI is loaded whereas the events need subscription first.
  • Color: More output formats would be better. RGB, RGBA etc all as strings. But not visible in the UI, just a parameter.

@danielpeintner
Copy link
Member

A general request:
In

  • ui-wot/packages/generator
  • ui-wot/packages/components

we have README.md which are empty. I think a basic readme what the packages are for makes sense
OR
you link them from the main README, but then I suggest removing the empty readmes in the packages folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants