-
Notifications
You must be signed in to change notification settings - Fork 87
Avoid eslint warnings #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid eslint warnings #1431
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1431 +/- ##
==========================================
- Coverage 77.58% 77.46% -0.13%
==========================================
Files 79 83 +4
Lines 15331 15852 +521
Branches 1445 1506 +61
==========================================
+ Hits 11894 12279 +385
- Misses 3414 3549 +135
- Partials 23 24 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Note: With this PR I would like to avoid "all" warnings and I plan to work on each warning in a separate PR to turn it on and raise an "error" to notify issues rather than "warn" which doesn't get noticed in our CI runs |
Are you okay with the approach mentioned above? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the direction and I am fine with it. If most of the ignores are removed by the 1.0 release, it is fine :)
By
see #1430