Skip to content

Conversation

danielpeintner
Copy link
Member

By

  • turning off some warnings
  • fix warnings like unused eslint-disable directive by removing useless command

see #1430

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.46%. Comparing base (3325e12) to head (25f69a8).
⚠️ Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
packages/binding-mbus/src/mbus-connection.ts 0.00% 1 Missing ⚠️
...ckages/binding-modbus/src/modbus-client-factory.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
- Coverage   77.58%   77.46%   -0.13%     
==========================================
  Files          79       83       +4     
  Lines       15331    15852     +521     
  Branches     1445     1506      +61     
==========================================
+ Hits        11894    12279     +385     
- Misses       3414     3549     +135     
- Partials       23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielpeintner
Copy link
Member Author

Note: With this PR I would like to avoid "all" warnings and I plan to work on each warning in a separate PR to turn it on and raise an "error" to notify issues rather than "warn" which doesn't get noticed in our CI runs

@danielpeintner
Copy link
Member Author

Note: With this PR I would like to avoid "all" warnings and I plan to work on each warning in a separate PR to turn it on and raise an "error" to notify issues rather than "warn" which doesn't get noticed in our CI runs

Are you okay with the approach mentioned above?

Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the direction and I am fine with it. If most of the ignores are removed by the 1.0 release, it is fine :)

@danielpeintner danielpeintner merged commit d08d5d2 into eclipse-thingweb:master Oct 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants