Skip to content

Fix race condition in MMenuItemTest by adding event loop processing #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

Fix race condition in MMenuItemTest by adding event loop processing #3450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/MMenuItemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,9 @@ public void execute(MUIElement uiElement, MMenuItem menuItem,
activePart.getContext().set("key", "active");
inactivePart.getContext().set("key", "inactive");

// Ensure all pending UI events are processed before triggering the menu item
contextRule.spinEventLoop();

assertFalse(executed[0]);

Object widget1 = menuItem.getWidget();
Expand Down Expand Up @@ -836,6 +839,10 @@ public void execute(MUIElement uiElement, MMenuItem menuItem,
activePart.getContext().set("key", "active");
inactivePart.getContext().set("key", "inactive");

// Ensure all pending UI events are processed before triggering the menu item
// This prevents race conditions where the handler may not be fully registered yet
contextRule.spinEventLoop();

assertFalse(executed[0]);
assertEquals(activePart, window.getContext().get(EPartService.class)
.getActivePart());
Expand Down
Loading