VirtualTableViewerTest: improve table update + force active shell #1005 #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
issue-1583-virtualtableviewertest
branch
4 times, most recently
from
ba1643e to
c89a7de
Compare
|
Failing test is unrelated and already documented: #1737 |
…ipse-platform#1005 Several test cases of VirtualTableViewerTest randomly fail. This includes explicit failures of testRenameWithSorter() and testContains() and silent failures of other test cases that simply return successfully even if the test actually failed. The reason is a missing processing of an update of the table data, which is most likely caused by the shell not having focus. With this change, the test execution ensures that in cases where an update of the table data is expected, the shell is forced active and events are processed until the data is finally set properly. In addition, early returns producing silent failures are replaced by assertions leading to explicit failures in case the condition is still not met. Contributes to eclipse-platform#1583 May fix eclipse-platform#1005
HeikoKlare
force-pushed
the
issue-1583-virtualtableviewertest
branch
from
c89a7de to
33c75f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several test cases of VirtualTableViewerTest randomly fail. This includes explicit failures of testRenameWithSorter() and testContains() and silent failures of other test cases that simply return successfully even if the test actually failed. The reason is a missing processing of an update of the table data, which is most likely caused by the shell not having focus.
With this change, the test execution ensures that in cases where an update of the table data is expected, the shell is forced active. In addition, early returns producing silent failures are replaced by assertions leading to explicit failures in case the condition is still not met.
In case tests that previously failed silently now start to fail explicitly despite the changes, I propose to disable them completely (which does make a difference to the current state, see #1583).
Contributes to #1583
May fix #1005