Dispose activity management during shutdown completely and early #1084 #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2023
Test Results 854 files - 1 854 suites - 1 1h 38m 40s ⏱️ - 15m 59s For more details on these failures, see this check. Results for commit 7a945f5. ± Comparison against base commit 6683f3f. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
issue-1084-shutdown
branch
2 times, most recently
from
ec9d448 to
6d2ae4a
Compare
fedejeanne
reviewed
Sep 12, 2023
...ipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/AbstractActivityManager.java
Outdated
Show resolved
Hide resolved
fedejeanne
reviewed
Sep 12, 2023
...ipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/AbstractActivityManager.java
Outdated
Show resolved
Hide resolved
fedejeanne
reviewed
Sep 12, 2023
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
sratz
reviewed
Sep 12, 2023
...lipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/MutableActivityManager.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
issue-1084-shutdown
branch
4 times, most recently
from
ada4186 to
26964bb
Compare
HeikoKlare
force-pushed
the
issue-1084-shutdown
branch
from
26964bb to
b3434db
Compare
vogella
force-pushed
the
issue-1084-shutdown
branch
from
b3434db to
f818ddc
Compare
|
@HeikoKlare can this be merged? |
|
Yes, it's ready to merge. I've only been waiting for the end of the M1 freeze period. |
Master is open now, so please merge after the verification build. |
…pse-platform#1084 The WorkbenchActivitySupport is currently disabled quite late during workbench shutdown. In particular, it is performed after the service locator disposal, which produces several events for the disablement of expression-controlled activities that are processed by the activity management. Since the activity management is shut down afterwards anyway, the processing of these events is unnecessary. This change ensures that activities enablement changes are not unnecessarily processed during workbench shutdown. It consists of two parts: 1. It performs the disposal of activity management and its persistence handler early in the workbench shutdown process (in particular before the service locator disposal). 2. It adds proper dispose functionality for the IActivityManager, such that disposing the workbench activity support disposes the activity manager, which then removes all its listeners to not react to further events. Contributes to eclipse-platform#1084.
HeikoKlare
force-pushed
the
issue-1084-shutdown
branch
from
f818ddc to
7a945f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WorkbenchActivitySupportis currently disabled quite late during workbench shutdown. In particular, it is performed after the service locator disposal, which produces several events for the disablement of expression-controlled activities that are processed by the activity management. Since the activity management is shut down afterwards anyway, the processing of these events is unnecessary.This change ensures that activities enablement changes are not unnecessarily processed during workbench shutdown. It consists of two parts:
Contributes to #1084.