Skip to content

Conversation

@juliapampus
Copy link
Contributor

What this PR changes/adds

  1. Allows .well-known endpoint to be located at base and not host URL
  2. Changes service discovery via DID document, allowing for CatalogService and DataService (Connector)
  3. Move Sec 5.4.5 to Sec 4

Why it does that

Address requirements of adopters:

  • flexibility in service discovery
  • flexibility in service deployment

while aiming for interoperability within and across dataspaces.

Further notes

Related issue #168 to be addressed in a future PR

Linked Issue(s)

Relates #146

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor wording fixes.

@lgblaumeiser
Copy link

Love that 😃

Two suggestion, though, if I may.

  • An explicit remark in the did document section, that the service reference may be enhanced with further properties is not necessary but would help in adoption, as some discussion might be avoided.
  • Perhaps it is worth a thought, that for a placement of the dspace-version endpoint not according to the rfc8615, the .well-known path part could be omitted, as this would potentially prevent discussions about the "wrong" adoption of the rfc.

@arnoweiss
Copy link
Contributor

Love that 😃

Two suggestion, though, if I may.

  • An explicit remark in the did document section, that the service reference may be enhanced with further properties is not necessary but would help in adoption, as some discussion might be avoided.
  • Perhaps it is worth a thought, that for a placement of the dspace-version endpoint not according to the rfc8615, the .well-known path part could be omitted, as this would potentially prevent discussions about the "wrong" adoption of the rfc.

We discussed both.

  • The first suggestion is better placed in the best practices. I'll update those to the state of the spec as soon as this PR is merged. (Adjust section on versioning and deployment BestPractices#16)
  • That would mean that the application logic implementing the endpoint would have to be aware about how it's deployed. And that's something that we're trying to avoid altogether with this PR.

@matbmoser
Copy link

Really good idea! Thank you!

@juliapampus juliapampus force-pushed the feat/version-discovery branch from 0e7036e to 19c0492 Compare June 6, 2025 06:49
@juliapampus juliapampus merged commit 63e7ef0 into eclipse-dataspace-protocol-base:main Jun 6, 2025
3 checks passed
@juliapampus juliapampus deleted the feat/version-discovery branch June 6, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants