-
Notifications
You must be signed in to change notification settings - Fork 14
feat: change service and version discovery #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliapampus
merged 9 commits into
eclipse-dataspace-protocol-base:main
from
FraunhoferISST:feat/version-discovery
Jun 6, 2025
Merged
feat: change service and version discovery #169
juliapampus
merged 9 commits into
eclipse-dataspace-protocol-base:main
from
FraunhoferISST:feat/version-discovery
Jun 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnoweiss
approved these changes
Jun 5, 2025
jimmarino
approved these changes
Jun 5, 2025
Contributor
jimmarino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor wording fixes.
|
Love that 😃 Two suggestion, though, if I may.
|
Contributor
We discussed both.
|
mkollenstart
approved these changes
Jun 5, 2025
|
Really good idea! Thank you! |
0e7036e to
19c0492
Compare
63e7ef0
into
eclipse-dataspace-protocol-base:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
.well-knownendpoint to be located atbaseand nothostURLCatalogServiceandDataService(Connector)Why it does that
Address requirements of adopters:
while aiming for interoperability within and across dataspaces.
Further notes
Related issue #168 to be addressed in a future PR
Linked Issue(s)
Relates #146
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.