Skip to content
This repository was archived by the owner on Feb 2, 2022. It is now read-only.

Conversation

@JamesDrummond
Copy link

  1. Copied everything from eclipse/che repo BUT /dockerfiles/Che-server folder. Removed the leading /dockerfiles folder after the move. Copied /dockerfiles/che-server/Dockerfile file to root directory.
  2. Copied the contents of the codenvy/dockerfiles repo to a directory called /recipes.

…r folder. Removed the leading /dockerfiles folder after the move. Copied /dockerfiles/che-server/Dockerfile file to root directory.

2. Copied the contents of the codenvy/dockerfiles repo to a directory called /recipes.
@JamesDrummond
Copy link
Author

Need to change the commiter email. used gmail instead of codenvy.


ENTRYPOINT [ "/home/user/che/bin/che.sh", "-c" ]

CMD [ "run" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be in this repository. This file should remain in /che repository, but moved from /dockerfiles/che-server/Dockerfile to be just /Dockerfile. We can then delete the /dockerfiles/che-server directory.

Also note - if you move this file to the root of the Che repo, then the comment on how to build this dockerfile needs to change. The syntax is then wrong (has the wrong context.

@TylerJewell
Copy link
Contributor

@eivantsov @benoitf @riuvshin - please take a look. Assuming that we can still release and build images independently of Che, are you comfortable with the overall structure?

@TylerJewell
Copy link
Contributor

@JamesDrummond - please verify that every file has appropriate license + copyright header in the opening comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants