Changing 'dummy' toolchain in bootstrap to 'system' #3247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first naive attempt did not take into account the checksum and version check on bootstrap_eb.py. Trying to fix that here. Incremented version from .01 to .02 and updated .travis.yml with new sha256sum for bootstrap_eb.py
Corrected version to Mar 15, updated sha25sum. I am not understanding
why it is failing. When I copy the lines from .travis.yml into a
shell script and run, it seems to work.
$ cat my_test.sh
TRAVIS_BUILD_DIR=.
# version and SHA256 checksum are hardcoded below to avoid forgetting to update the version in the script along with contents
EB_BOOTSTRAP_VERSION=$(grep '^EB_BOOTSTRAP_VERSION' $TRAVIS_BUILD_DIR/easybuild/scripts/bootstrap_eb.py | sed 's/[^0-9.]//g')
EB_BOOTSTRAP_SHA256SUM=$(sha256sum $TRAVIS_BUILD_DIR/easybuild/scripts/bootstrap_eb.py | cut -f1 -d' ')
EB_BOOTSTRAP_FOUND="$EB_BOOTSTRAP_VERSION $EB_BOOTSTRAP_SHA256SUM"
EB_BOOTSTRAP_EXPECTED="20200315.01 f8c5958b9ce839a9aa1defe968f7c1d84d10b6befc4da697c3cd2571172cf86d"
test "$EB_BOOTSTRAP_FOUND" = "$EB_BOOTSTRAP_EXPECTED" && (echo "Version check on bootstrap script succeeded $EB_BOOTSTRAP_FOUND")
$ bash my_test.sh
Version check on bootstrap script succeeded 20200315.01 f8c5958b9ce839a9aa1defe968f7c1d84d10b6befc4da697c3cd2571172cf86d
|
Hi @justbennet thanks for the PR, there is actually an open PR #3211 that also fixes this along with some other issues with the bootstrap script. That PR takes into account that people may still want to bootstrap in an older version (3.x) of EB where In general, there are quite a few open issues with the bootstrap script (see #3223) and we probably need a deeper fix. |
|
Thanks, @ocaisa . I will close this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dummytoolchain was being used in the bootstrap script and generating a deprecation warning.Changed to
system. Warning is no longer issued.