Skip to content

Conversation

@ajxb
Copy link
Contributor

@ajxb ajxb commented May 14, 2020

Vagrant 2.2.8 introduced explicit handling of CentOS as a guest in the commit hashicorp/vagrant@5104d07

This causes the vagrant-sshfs plugin to skip the installation of fuse-sshfs because the returned value of machine.guest.capability("flavor") is now :centos, :centos_7, or :centos_8 depending on the version of the guest machine. A consequence of this is that any attempt to mount any folder via sshfs fails.

This change introduces handling for CentOS to fix this problem in versions of Vagrant from 2.2.8 onwards.

@pgporada
Copy link

This solved my problem using centos 7 and 8 vagrants.

@dustymabe
Copy link
Owner

thanks @ajxb - i'll try to get around to testing and merging this soon

@barnabycourt
Copy link

@dustymabe Is there anything those of us using centos based images & sshfs can do to help move this along?

@pvalena
Copy link

pvalena commented Jun 15, 2020

@codylane
Copy link

codylane commented Jun 26, 2020

@dustymabe Is there anything those of us using centos based images & sshfs can do to help move this along?

@dustymabe - I hope you are doing well. Also thank you for creating such a nice plugin. :)

I realize you are busy and that you have other priorities and life challenges but it would be great if one of the maintainers could bless and or address this pull request. I'm happy to help anyway I can make the OSS community a better place for all and squash bugs when they get introduced. I'm not sure if you are open to this but If you'd like some help I'd love to help you by being a maintainer or collaborator to help you maintain this plugin? FWIW, I also maintain vagrant-proxyconf .

Also for what it's worth, there really is no code change here. When Vagrant 2.2.8 was released one of their engineers introduced a bug, I caught it within 12 hours and submitted the fix.

TL;DR to make this easier to grasp and to get back to a working state all we really need to do is symlink lib/vagrant-sshfs/cap/guest/redhat to lib/vagrant-sshfs/cap/guest/centos, however to be portable and backwards compatible what @ajxb submitted is a probably the best solution which is to just copy the what's in the redhat directory into the centos directory and update the cap files. Thanks @ajxp for posting the solution and providing such helpful info.

@dustymabe
Copy link
Owner

Thanks @ajxb. Sorry for the delay. I'll merge this and add some fixups and then put out a new release.

@dustymabe dustymabe merged commit dd02e09 into dustymabe:master Jun 29, 2020
@dustymabe
Copy link
Owner

@dustymabe - I hope you are doing well. Also thank you for creating such a nice plugin. :)

Thanks @codylane. I appreciate it.

I realize you are busy and that you have other priorities and life challenges but it would be great if one of the maintainers could bless and or address this pull request. I'm happy to help anyway I can make the OSS community a better place for all and squash bugs when they get introduced. I'm not sure if you are open to this but If you'd like some help I'd love to help you by being a maintainer or collaborator to help you maintain this plugin? FWIW, I also maintain vagrant-proxyconf .

This project could definitely use some love. There are various open issues that might be something you could help with. I could definitely use someone to help collaborate and maybe co-maintain in the future. Also if you use Windows at all any validation testing on WSL would be nice.

Regarding vagrant-proxyconf, maybe that could help with #104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants