Receiving from SQS: Updated README.md with working example #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivertappin
force-pushed
the
hotfix/40
branch
from
d68898d to
36ad595
Compare
dusterio
reviewed
Dec 10, 2019
| public function getRawBody() {} | ||
|
|
||
| public function getJobId() {} | ||
| } |
There was a problem hiding this comment.
actually, I think we can just remove "extends Job" completely (and therefore the two extra methods). All Laravel needs from a job class is the "handle" method, nothing else matters. This is the reason for confusion I think
There was a problem hiding this comment.
Correct, I have used it like that (without extending Job) as a normal Laravel job and it works like a charm on the latest version 0.1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #40