[CredentialsImport] Show credential import on credential inputs only #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size change (main vs. current)autofill.js: 757.50 KB -> 757.50 KB |
dbajpeyi
force-pushed
the
dbajpeyi/fix/credential-import-on-identities
branch
5 times, most recently
from
4ce5d84 to
0d73891
Compare
dbajpeyi
changed the title
After the fix! |
dbajpeyi
commented
Oct 3, 2025
packages/messaging/webkit.js
Outdated
|
|
||
| const cipher = new this.globals.Uint8Array([...ciphertext, ...tag]); | ||
| /** @ts-expect-error Type mismatch of key with BufferSource, and this code will be removed soon as it's not used */ | ||
| const decrypted = await this.decrypt(cipher, key, iv); |
There was a problem hiding this comment.
FYI, there's type mistmatch after the update but this encrypt/decrypt will be removed when getting rid of catalina support anyway! They are not used.
dbajpeyi
force-pushed
the
dbajpeyi/fix/credential-import-on-identities
branch
from
83f3f2b to
22d189f
Compare
|
Sadly this PR breaks all extension tests because of manifest updates expected by the newer chrome versions 🤷 I will have to spend a bit more time here. |
dbajpeyi
force-pushed
the
dbajpeyi/fix/credential-import-on-identities
branch
from
454ff7d to
eb97038
Compare
|
Been a while since last review, I mainly rebased the PR as extension manifest is now updated in #910 and this PR is unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana:
Description
On https://www.alibris.com/account the import dialog can show up in an identity field if the form is login, and has a identity field (should be a rare case).
credentials,Steps to test