[CustomElements] use safer captured customelements #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FormAnalyzer to use a safer approach for accessing the customElements API by referencing it through globalThis.customElements instead of the global customElements variable.
- Changes direct
customElementsreference toglobalThis.customElementsto prevent issues if the global variable is overridden - Maintains existing null-safe access pattern with optional chaining
dbajpeyi
force-pushed
the
dbajpeyi/global-this-custom-elements
branch
from
50838ce to
d2a33f4
Compare
dbajpeyi
changed the title
muodov
approved these changes
Jul 17, 2025
|
Nvm, I will re-visit this to fix the tests. |
|
@dbajpeyi Let us know when the tests are updated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation @muodov
cc: @borgateo
Asana:
Description
Safer access to global customElements via
c-s-s.captured-globals.js, in case the variable is redefined or shadowed.Steps to test