Skip to content

Conversation

pdcastro
Copy link

@pdcastro pdcastro commented Feb 8, 2020

Addresses /issues/201

@ds300
Copy link
Owner

ds300 commented Feb 10, 2020

Hey, thanks for raising this issue! 🙏 I think the root of this problem is higher up, in getPackageDetailsFromPatchFilename, and it should be fixed there rather than here. Do you have time/desire to try fixing that? No worries if not, I can get around to it this week.

to be clear, the version string returned from getPackageDetailsFromPatchFilename should not contain the .dev suffix. I had a quick look and it attempts to remove it at least.

@pdcastro
Copy link
Author

Do you have time/desire to try fixing that? No worries if not, I can get around to it this week.

@ds300, thank you for reviewing this PR. I suspected all along that this PR was a pain killer rather than a cure. :-) I don't have much time so I am closing it, and I will leave it for you to properly fix the issue in another PR.

By the way, before I created this PR, my first attempt was to use patch-package to patch itself (having that version regex replacement in a patch file), but it didn't work... I've now raised issue #203 to describe the experience. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants