update typed-css-modules #1
Conversation
|
@pyrocat101 is this something you would be open to merge in the future? |
| @@ -44,13 +43,6 @@ async function writeFile(dtsCreator: DtsCreator, cssFile: string): Promise<void> | |||
| // clears cache so that watch mode generates update-to-date typing. | |||
| const content = await dtsCreator.create(cssFile, undefined, true); | |||
| await content.writeFile(); | |||
| if (content.messageList.length > 0) { | |||
There was a problem hiding this comment.
@gdelmas why remove this?
There was a problem hiding this comment.
the new version of typed-css-modules no longer has a messagesList.
i guess the reason is, that it was only used to collect classnames that could not be emitted. yet the new version can emit all classnames now.
i therefore also updated the definition to reflect that in line 26.
There was a problem hiding this comment.
@gdelmas Sounds good. I will merge the PR if you can rebase.
|
@gdelmas Sorry for the delay in response. I just have one question about your PR. |
|
ping @gdelmas can you rebase your PR? |
|
@pyrocat101 yes. i will be doing it by end of the week. have no computer at hand currently. thanks for accepting it. |
gdelmas
force-pushed
the
update-typed-css-modules
branch
from
8dbcdfb to
05e6ebc
Compare
|
@pyrocat101 i rebased and updated the emit in the tests. hope all is fine. will you be releasing a new version to npm? |
|
@gdelmas Sorry for the delay. I just published 0.1.1 including your change. |
the new
typed-css-modulesversion comes with an improved emit style Quramy/typed-css-modules#56 that also supports classnames with dashes or for reserved words.messagesListno longer exists intyped-css-modulesas everything can be emitted.