Skip to content

Conversation

sderickson
Copy link
Contributor

@sderickson sderickson commented Jan 24, 2022

Adds the "scope" attribute to the exported clients, so that they appear in the docstrings of routes that have a scope defined.

After running:

python generate_base_client.py
tox -e docs

I checked the html build files and scopes are showing up as expected.

Screen Shot 2022-01-24 at 3 16 18 PM

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #408 (97eb2f4) into main (62e49c1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files          30       30           
  Lines       51451    51451           
  Branches     5729     5729           
=======================================
  Hits        33049    33049           
  Misses      18244    18244           
  Partials      158      158           
Flag Coverage Δ
integration 64.14% <ø> (ø)
unit 63.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e49c1...97eb2f4. Read the comment docs.

@sderickson
Copy link
Contributor Author

Pulled in stone 3.3.1 and ran the same manual test, still works.

@sderickson sderickson merged commit 2f8899f into main Jan 25, 2022
@sderickson sderickson deleted the add-scope branch January 25, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants