fix regression for as_user() and as_admin() #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qimingyuan
approved these changes
Feb 8, 2018
risforrob
force-pushed
the
rob/fix_regression_for_as_user_admin
branch
from
21644df to
de09f53
Compare
risforrob
force-pushed
the
rob/fix_regression_for_as_user_admin
branch
from
de09f53 to
e30886f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix my regression for
as_user()andas_admin()where they were returning an instance ofDropboxTeaminstead ofDropbox. Also added unit tests to not make this mistake in the future.