Skip to content

Make DependencyTracker.kt not store rootProject or logger so that its serializable again #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshafeinberg merged 3 commits into from
Aug 19, 2025
Merged

Make DependencyTracker.kt not store rootProject or logger so that its serializable again #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3468c31
Make DependencyTracker.kt not store rootProject or logger so that its…
joshafeinberg Aug 19, 2025
c2fe570
Remove logger from filtering android tasks
joshafeinberg Aug 19, 2025
5a345d3
Fix sample app
joshafeinberg Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...duledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ class AffectedModuleDetectorImpl(
*/
private fun findDependentProjects(): Set<ProjectPath> {
return changedProjects.flatMap { path ->
dependencyTracker.findAllDependents(path)
dependencyTracker.findAllDependents(path, logger)
}.toSet()
}

Expand Down
2 changes: 1 addition & 1 deletion ...tector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
val tracker = DependencyTracker(project, null)
project.tasks.configureEach { task ->
if (task.name.contains(ANDROID_TEST_PATTERN)) {
tracker.findAllDependents(project.projectPath).forEach { dependentProject ->
tracker.findAllDependents(project.projectPath, null).forEach { dependentProject ->
project.rootProject.findProject(dependentProject.path)?.tasks?.forEach { dependentTask ->
AffectedModuleDetector.configureTaskGuard(dependentTask)
}
Expand Down
4 changes: 2 additions & 2 deletions ...tedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/DependencyTracker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import java.io.Serializable
* Utility class that traverses all project dependencies and discover which modules depend on each
* other. This is mainly used by [AffectedModuleDetector] to find out which projects should be run.
*/
class DependencyTracker(private val rootProject: Project, private val logger: Logger?) : Serializable {
class DependencyTracker(rootProject: Project, logger: Logger?) : Serializable {

private val dependentList: Map<ProjectPath, Set<ProjectPath>> by lazy {
val result = mutableMapOf<ProjectPath, MutableSet<ProjectPath>>()
Expand All @@ -52,7 +52,7 @@ class DependencyTracker(private val rootProject: Project, private val logger: Lo
result
}

fun findAllDependents(projectPath: ProjectPath): Set<ProjectPath> {
fun findAllDependents(projectPath: ProjectPath, logger: Logger? = null): Set<ProjectPath> {
logger?.info("finding dependents of $projectPath")
val result = mutableSetOf<ProjectPath>()
fun addAllDependents(projectPath: ProjectPath) {
Expand Down