Skip to content

setRequestHeader add replace option #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

setRequestHeader add replace option #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ab8a5c
setRequestHeader add replace option
hzz780 Aug 22, 2018
38921f1
npm publish
hzz780 Aug 22, 2018
c86a521
.
hzz780 Aug 22, 2018
10a0974
name xmlhttprequest->@aelfqueen/xmlhttprequest
hzz780 Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/XMLHttpRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ exports.XMLHttpRequest = function() {
* @param string header Header name
* @param string value Header value
*/
this.setRequestHeader = function(header, value) {
this.setRequestHeader = function(header, value, isReplace) {
var isReplaceTemp = false || isReplace;
if (this.readyState !== this.OPENED) {
throw new Error("INVALID_STATE_ERR: setRequestHeader can only be called when state is OPEN");
}
Expand All @@ -202,6 +203,10 @@ exports.XMLHttpRequest = function() {
}
header = headersCase[header.toLowerCase()] || header;
headersCase[header.toLowerCase()] = header;
if (isReplaceTemp) {
headers[header] = value;
return;
}
headers[header] = headers[header] ? headers[header] + ', ' + value : value;
};

Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"name": "xmlhttprequest",
"name": "@aelfqueen/xmlhttprequest",
"description": "XMLHttpRequest for Node",
"version": "1.8.0",
"version": "1.8.1",
"author": {
"name": "Dan DeFelippi",
"url": "http://driverdan.com"
"name": "Dan DeFelippi, hzz780",
"url": "http://driverdan.com, https://github.com/hzz780/node-XMLHttpRequest"
},
"keywords": ["xhr", "ajax"],
"license": "MIT",
"repository": {
"type": "git",
"url": "git://github.com/driverdan/node-XMLHttpRequest.git"
"url": "git://github.com/hzz780/node-XMLHttpRequest.git"
},
"browser": "./lib/browser.js",
"bugs": "http://github.com/driverdan/node-XMLHttpRequest/issues",
"bugs": "http://github.com/hzz780/node-XMLHttpRequest/issues",
"engines": {
"node": ">=0.4.0"
},
Expand Down