This repository was archived by the owner on Jun 8, 2023. It is now read-only.
[Discussion] [Live Share] Restricting language services to local files #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragos
approved these changes
Apr 12, 2018
|
Thanks! |
|
@dragos Do you have plans to release an update to the marketplace any time soon? If possible, I'd love to have this change published as part of your next push. Thanks! |
|
I'll release this Friday. |
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 19, 2018
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 19, 2018
gsps
pushed a commit
to gsps/dotty
that referenced
this pull request
Apr 21, 2018
|
@dragos Did you plan to update the extension in the marketplace anytime soon? I'd love to have rock-solid Scala support in Live Share :) |
|
Yeah, I wish I could... now navigating the labyrinth of publishing, it seems my token expired after 1 year and can't get publishing to work anymore |
|
Ok, should be up on the marketplace now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for Visual Studio Live Share adding support for "guests" to receive remote language services for Scala, this PR simply updates the current
DocumentSelectorto be limited tofileanduntitled(unsaved) files. This way, when someone has the Scala extension installed, and joins a Live Share session (where files use thevsls:scheme), their language services will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience (guests in Live Share don't have local file access to the project they're collaborating with).Note: As an example, the TypeScript/JavaScript language services that come in-box with VS Code already have this scheme restriction, and so this PR replicates that behavior.