Limit enumeration in tests #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why is this a draft pull request to me it looks like it can be emrged? |
Guiorgy
force-pushed
the
limit-enumeration-in-tests
branch
from
cbace04 to
8c6ed13
Compare
Contributor
Author
|
The draft pull was a missclick, and the reorder commit was removed |
Member
|
Great, merging it |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an oversight in #9 that didn't account for the possibility that the implementation being tested could return infinite enumeration. This adds a
maxCountparameter to theToSystemEnumerableextension methods that throws an exception (stopping the test) if the SpanEnumerable returns more the specified number of spans.Note: This assumes that the underlying SpanEnumerable implementation returns spans. This will not detect if the implementation gets stuck in an infinite loop that never returns! Infinite recursions should be caught by the tests once they run out of stack memory.