-
Notifications
You must be signed in to change notification settings - Fork 5
Implemented Min() & Max() functions and updated README.md #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Min() & Max() functions and updated README.md #13
Conversation
|
Hey, Glad you like the project. Of course, PS: Opening an issue never hurts, but is unnecessary in this case, since your pr gives all needed information. |
|
I also started to work on |
|
@SadToBeNep If you plan to implement |
|
Great work - I'll merge it into a feature branch. I believe there are some missing overloads and implementing |
|
Also for performance reasons an if construct should be used instead of a ternary expression,to avoid unnecessary reassignments. |
Hello, I was using your lib for one of my project, and it was missing the .Min() function, so I added it
I am just learning C# and Git(Hub) too, so go easy on me if something
PS: Wasn't sure if I should open a Issue before the pull request