Skip to content

Conversation

@alexreg
Copy link
Contributor

@alexreg alexreg commented Oct 6, 2021

Fixed formatting and incorrect references. Added new parameters quote_keys, trailing_commas, allow_duplicate_keys.

Fixed formatting and incorrect references. Added new parameters `quote_keys`, `trailing_commas`, `allow_duplicate_keys`.
@alexreg alexreg changed the title Improved docs for dump and dumps functions. Improved docs for dump and dumps functions Oct 6, 2021
@dpranke
Copy link
Owner

dpranke commented Oct 6, 2021

Thanks for the change! It looks good.

Can I get you to agree to the Google Contributors License Agreement? See https://opensource.google/docs/cla/ and https://cla.developers.google.com/ .

I'm actually a Google employee and at some point I'll probably transfer this repo over into the Google namespace, and if you're willing to agree to that that'll make things slightly simpler for me.

@alexreg
Copy link
Contributor Author

alexreg commented Oct 6, 2021

No problem. Just signed the agreement.

@dpranke
Copy link
Owner

dpranke commented Oct 11, 2021

Thanks!

@dpranke dpranke merged commit 17f87c0 into dpranke:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants