Added ServerlessDeploymentBucket handling for Serverless V4 #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This worked for me with V4. Why isn't this fixed / merged yet? |
|
This also worked for me with Serverless v4. It fix issue when splitter v1.14.0 and Serverless v4 cause error:
|
|
@dougmoscrop Any chance you can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added logic to allow deployments in serverless V4 with an existing bucket. It doesn't create a new bucket per each service when you have multiple services. It'll use a bucket per project and reuse it with different services.
I've tested it on the latest version of Serverless and it's working fine. However, I did not test it with a Serverless v2 or v3 project, although it should work.
Also, I've modified the tests to accommodate this behavior.