Remove OleCmdHelper/ISecureCommand dead code (CAS/XBAP leftovers) #9943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
harshit7962
added
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
harshit7962
previously approved these changes
Dec 31, 2024
Member
harshit7962
left a comment
harshit7962
left a comment
There was a problem hiding this comment.
LGTM.
@h3xds1nz, the PR can be merged post resolution of conflicts.
h3xds1nz
force-pushed
the
remove-more-browser-stuff
branch
from
cd58666 to
bfa8712
Compare
Member
Author
|
@harshit7962 Resolved. |
harshit7962
approved these changes
Dec 31, 2024
Member
harshit7962
left a comment
harshit7962
left a comment
There was a problem hiding this comment.
Reapproving after resolution of merge conflicts.
Member
|
@h3xds1nz Thank you for your continued contributions. |
Member
Author
|
@harshit7962 Thanks for iteratively working through them :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continues #9855 and #9865, removing even more XBAP related dead code (and some CAS related code).
OleCmdHelperis uncalled,CommandWithArgumentwas only used inOleCmdHelper.ISecureCommandwas also referenced viaOleCmdHelperthough it has been gutted out during CAS removal.SecureUICommandwas created usingCommandLibraryHelperon NetFX, removed during CAS removal too.Customer Impact
Smaller assembly size, improved code base quality for developers.
Regression
No.
Testing
Local build.
Risk
I believe there is none, those classes are uncalled and interface unused since CAS removal.
Microsoft Reviewers: Open in CodeFlow