Enable PresentationCore tests #9471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
PR
ThomasGoulet73
commented
Jul 26, 2024
ThomasGoulet73
commented
Jul 26, 2024
ThomasGoulet73
commented
Jul 26, 2024
src/Microsoft.DotNet.Wpf/tests/UnitTests/Directory.Build.targets
Outdated
Show resolved
Hide resolved
ThomasGoulet73
commented
Jul 26, 2024
ThomasGoulet73
commented
Jul 26, 2024
Contributor
Author
|
It seems to be failing but only when built in Release, I'll investigate. |
Contributor
Author
|
The tests seems to be succeeding now. |
Member
|
@ThomasGoulet73 big thanks for your contribution! |
rchauhan18
approved these changes
Jul 26, 2024
Contributor
rchauhan18
left a comment
rchauhan18
left a comment
There was a problem hiding this comment.
@ThomasGoulet73 Thanks for your contribution!
Contributor
Author
|
Thanks @rchauhan18 |
Merged
ericstj
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Run PresentationCore tests * Use previously built package native files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables PresentationCore tests.
@adamsitnik noted here #9465 (comment) that PresentationCore.Tests was not included so the tests were not running. By reading the commit messages in #8532 it seems like they were disabled temporarily but I don't know why. I took it upon myself on enabling them and fixing the build and runtime errors (I don't know if they were the cause on why they were disabled).
It also fixes the build errors and some runtime errors in #8215 but WindowsBase.Tests would need some changes to completely fix it and I plan on working on it once this PR is merged.
I hope I didn't step on anyone's toes if they were working on it.
Customer Impact
WPF would be more tested.
Regression
No.
Testing
Local build + tests passing locally.
Risk
None, shouldn't affect shipping binaries.
Microsoft Reviewers: Open in CodeFlow