[main] Update dependencies from dotnet/arcade #8030

dotnet-maestro · 2023-07-13T12:21:06Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: 840bf684-917a-4879-f62c-08d8e93a0c51
Build: 20230809.5
Date Produced: August 9, 2023 3:51:11 PM UTC
Commit: bebd2de1988036b47ecefc7e72b66ce2f403e43d
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.ApiCompat: from 8.0.0-beta.23361.1 to 8.0.0-beta.23409.5
- Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23361.1 to 8.0.0-beta.23409.5
- Microsoft.DotNet.CodeAnalysis: from 8.0.0-beta.23361.1 to 8.0.0-beta.23409.5
- Microsoft.DotNet.GenAPI: from 8.0.0-beta.23361.1 to 8.0.0-beta.23409.5
- Microsoft.DotNet.Helix.Sdk: from 8.0.0-beta.23361.1 to 8.0.0-beta.23409.5

Microsoft Reviewers: Open in CodeFlow

…712.5 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23362.5

ghost

Go, you big red fire engine!

singhashish-wpf · 2023-07-14T05:15:09Z

/azp run

azure-pipelines · 2023-07-14T05:15:15Z

No commit pushedDate could be found for PR 8030 in repo dotnet/wpf

…713.3 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23363.3

mmitche · 2023-07-14T14:29:11Z

This has something to do with sourcelink moving into the SDK.

…714.2 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23364.2

dipeshmsft · 2023-07-17T06:02:53Z

/azp run

azure-pipelines · 2023-07-17T06:03:02Z

Azure Pipelines successfully started running 1 pipeline(s).

lewing · 2023-07-18T00:08:13Z

cc @ViktorHofer

ViktorHofer · 2023-07-18T06:45:05Z

cc @ViktorHofer

Thanks for the ping. We have been discussing this for the last days as it isn't exactly clear how to respond to vcxproj support. We believe we found an option and will now work on a fix.

…719.2 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23369.2

…720.6 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23370.6

…721.1 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23371.1

singhashish-wpf · 2023-07-24T05:17:40Z

@ViktorHofer Do we have a way to address this failure? Please inform if there is something required from wpf side.

ViktorHofer · 2023-07-24T15:18:19Z

@tmat @mmitche I'm out this week and couldn't complete a fix (as we discussed offline). Would you be able to help out here? Otherwise I can revisit this when I'm back, next week.

We could still consider adding the package references directly just here or in Arcade.Sdk.

…726.1 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23376.1

…727.1 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23377.1

…728.2 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23378.2

singhashish-wpf · 2023-07-31T05:02:41Z

@ViktorHofer @mmitche Is there something which is to be done from wpf side? This has been blocked for a week now.

ViktorHofer · 2023-07-31T09:43:03Z

I'm back this week and will continue my investigation.

…731.1 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23381.1

…801.3 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23401.3

…802.2 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23402.2

…803.7 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23403.7

…804.2 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23404.2

singhashish-wpf · 2023-08-07T04:58:14Z

/azp run

azure-pipelines · 2023-08-07T04:58:24Z

Azure Pipelines successfully started running 1 pipeline(s).

ViktorHofer · 2023-08-07T08:16:56Z

We are still in the same state and I had to shift to something high prio last week. Will chat with @mmitche about this.

…807.1 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23407.1

…808.6 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23408.6

…809.5 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23409.5

…cb21-4105-8301-6c61cb960ec3

Sourcelink support was removed from arcade and is now provided by the .NET SDK. Since the .NET sdk targets aren't automatically brought in, add appropriate package references when building vcxproj.

mmitche · 2023-08-10T22:36:19Z

I think I've got this resolved. PTAL

mmitche · 2023-08-11T01:44:14Z

Well, Maestro just up and merged that. Feel free to review and we can change if need be.

ThomasGoulet73 · 2023-08-11T02:13:01Z

eng/common/CIBuild.cmd

@@ -1,2 +1,2 @@
 @echo off
-powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0Build.ps1""" -restore -build -sign -pack -publish -ci %*"
+powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0Build.ps1""" -restore -build -test -sign -pack -publish -ci %*"


It looks like this PR reverted some changes from #8013.

eng/common/* is 'controlled' by the arcade repo and shouldn't be checked into. Any changes there would be overwritten on the next arcade update. The right way to do that is to make an eng/cibuild.cmd which calls build.ps1 the way you want and use that in CI scripts.

@ThomasGoulet73 - We've moved the scripts here - #8036

@pchaurasia14 Alright thanks, just wanted to make sure it didn't break anything since I remembered seeing manual changes to these files.

ViktorHofer · 2023-08-11T14:28:32Z

Thanks a lot Matt 👍

dotnet-maestro bot requested a review from a team as a code owner July 13, 2023 12:21

ghost approved these changes Jul 13, 2023

View reviewed changes

ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 13, 2023

ghost requested review from dipeshmsft and singhashish-wpf July 13, 2023 12:21

mmitche and others added 2 commits July 14, 2023 07:36

Set dependency on sourcelink provided target

be318cd

pchaurasia14 mentioned this pull request Jul 18, 2023

[main] Update dependencies from dotnet/winforms #8035

Merged

dotnet-maestro bot added 3 commits July 20, 2023 12:12

dotnet-maestro bot added 3 commits July 27, 2023 12:12

dotnet-maestro bot added 3 commits August 1, 2023 12:11

dotnet-maestro bot added 2 commits August 4, 2023 12:13

dotnet-maestro bot and others added 6 commits August 8, 2023 12:11

Merge remote-tracking branch 'upstream/main' into darc-main-044f1e8c-…

f9cb8fd

…cb21-4105-8301-6c61cb960ec3

Work around sourcelink removal from arcade

a6e8154

Sourcelink support was removed from arcade and is now provided by the .NET SDK. Since the .NET sdk targets aren't automatically brought in, add appropriate package references when building vcxproj.

Move vcxproj conditional up one level

d8dba64

dotnet-maestro bot merged commit 6f41c13 into main Aug 10, 2023

dotnet-maestro bot deleted the darc-main-044f1e8c-cb21-4105-8301-6c61cb960ec3 branch August 10, 2023 22:46

ThomasGoulet73 reviewed Aug 11, 2023

View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 10, 2023

[main] Update dependencies from dotnet/arcade #8030

[main] Update dependencies from dotnet/arcade #8030

Uh oh!

Conversation

dotnet-maestro bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/arcade

Microsoft Reviewers: Open in CodeFlow

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

singhashish-wpf commented Jul 14, 2023

Uh oh!

azure-pipelines bot commented Jul 14, 2023

Uh oh!

mmitche commented Jul 14, 2023

Uh oh!

dipeshmsft commented Jul 17, 2023

Uh oh!

azure-pipelines bot commented Jul 17, 2023

Uh oh!

lewing commented Jul 18, 2023

Uh oh!

ViktorHofer commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

singhashish-wpf commented Jul 24, 2023

Uh oh!

ViktorHofer commented Jul 24, 2023

Uh oh!

singhashish-wpf commented Jul 31, 2023

Uh oh!

ViktorHofer commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

singhashish-wpf commented Aug 7, 2023

Uh oh!

azure-pipelines bot commented Aug 7, 2023

Uh oh!

ViktorHofer commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmitche commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmitche commented Aug 11, 2023

Uh oh!

ThomasGoulet73 Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

mmitche Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

pchaurasia14 Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

ThomasGoulet73 Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

ViktorHofer commented Aug 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dotnet-maestro bot commented Jul 13, 2023 •

edited

Loading

ViktorHofer commented Jul 18, 2023 •

edited

Loading

ViktorHofer commented Jul 31, 2023 •

edited

Loading

ViktorHofer commented Aug 7, 2023 •

edited

Loading

mmitche commented Aug 10, 2023 •

edited

Loading