Reduce allocations when tracing routed events #6700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
bgrainger
commented
Jun 17, 2022
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/EventRoute.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Jun 20, 2022
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/EventRoute.cs
Outdated
Show resolved
Hide resolved
singhashish-wpf
added
DrtsPassed
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Thank you @bgrainger for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was tracing an application with dotMemory and noticed a huge amount of temporary
object[]being allocated byEventRoute.InvokeHandlersImpl.This particular application had attached a listener to
PresentationTraceSources.RoutedEventSourceto trace some diagnostic information. While it's expected that doing so will add some overhead, it shouldn't be this great.Customer Impact
Merging this PR will greatly reduce allocations for customers whose applications add a listener to
PresentationTraceSources.RoutedEventSource.Listeners.Regression
No.
Testing
Tested with dotMemory after shipping this fix in https://github.com/Faithlife/wpf.
Risk
Minimal.
Microsoft Reviewers: Open in CodeFlow