Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Conversation

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Apr 3, 2017

This is necessary because of dotnet/sdk#1053

@ericstj @weshaggard

@dsplaisted - I know you are working on moving this logic to the dotnet/sdk. Giving you a heads up in case this logic is still duplicated in your port.

@dnfclas
Copy link

dnfclas commented Apr 3, 2017

@eerhardt,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@eerhardt
Copy link
Member Author

eerhardt commented Apr 3, 2017

We should not merge this change until dotnet/sdk#1053 makes its way into the dotnet/cli.

@eerhardt
Copy link
Member Author

eerhardt commented Apr 4, 2017

The underlying change is in the dotnet/sdk. PTAL.

@ericstj
Copy link
Member

ericstj commented Apr 6, 2017

@eerhardt LMK if you need someone to merge this, otherwise go ahead when you're ready

@eerhardt eerhardt merged commit b6531c3 into master Apr 6, 2017
@eerhardt eerhardt deleted the SelfContained branch April 6, 2017 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants