Errors with beta 2

[clairernovotny]

Tryign to use beta 2 gives me these errors

 StrictFilePathMarshaler must be used on a FilePath. [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]                                                                                                              
    at LibGit2Sharp.Core.StrictFilePathMarshaler.MarshalManagedToNative(Object managedObj) [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]                                                                        
    at System.StubHelpers.MngdRefCustomMarshaler.ConvertContentsToNative(IntPtr pMarshalState, Object& pManagedHome, IntPtr pNativeHome) [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]                          
    at LibGit2Sharp.Core.NativeMethods.git_repository_discover(GitBuf buf, FilePath start_path, Boolean across_fs, FilePath ceiling_dirs) [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]                         
    at LibGit2Sharp.Core.Proxy.<>c__DisplayClass219_0.<git_repository_discover>b__0(GitBuf buf) [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]                                                                   
    at LibGit2Sharp.Core.Proxy.ConvertPath(Func`2 pathRetriever) [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]                                                                                                  
    at LibGit2Sharp.Core.Proxy.git_repository_discover(FilePath start_path) [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]                                                                                       
    at LibGit2Sharp.Repository.Discover(String startingPath) [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]                                                                                                      
    at Microsoft.Build.Tasks.Git.GitOperations.LocateRepository(String directory) in /_/src/Microsoft.Build.Tasks.Git.Operations/GitOperations.cs:line 26 [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]         
    at Microsoft.Build.Tasks.Git.RepositoryTasks.LocateRepository(LocateRepository task) in /_/src/Microsoft.Build.Tasks.Git.Operations/RepositoryTasks.cs:line 58 [C:\dev\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool\NuGetKeyVaultSignTool.csproj]

Using 1.0.0-beta-63127-02 works correctly, 1.0.0-beta2-18618-05 does not.

[tmat]

@bording

[tmat]

Odd, this looks like basic functionality that's well covered by tests. We are also using 1.0.0-beta2-18618-05 in our repos and I haven't seen a failure like this.

[bording]

@onovotny Do you have a repro? Like @tmat said, that should be some pretty basic usage of LibGit2Sharp, so it's surprising to see that sort of error.

[clairernovotny]

This repro'd for me both locally and on CI build for https://github.com/onovotny/NuGetKeyVaultSignTool

Just change the version in the props file: https://github.com/onovotny/NuGetKeyVaultSignTool/blob/master/Directory.Build.Props

CI build:
https://dev.azure.com/onovotny/GitBuilds/_build/results?buildId=1579

Look at the Pack step, at the bottom its log file, same problem.

[bording]

@onovotny I see that you're referencing both Microsoft.SourceLink.GitHub and Nerdbank.GitVersioning. Could you temporarily remove Nerdbank.GitVersioning and see if the problem still occurs?

Looking at the historical issues around that caused "StrictFilePathMarshaler must be used on a FilePath" errors, it's been related to having more than one copy of LibGit2Sharp in memory.

Those sorts of problems should have been mitigated, but I'm wondering if there is some new reason it would be causing a problem.

[tmat]

@onovotny Does removing Nerdbank.GitVersioning fix the issue?

[clairernovotny]

Sorry, have not had a chance to take a look yet

[clairernovotny]

It still repros for that even when I remove NB.GV.

[clairernovotny]

Any ideas?

[bording]

@onovotny What do I need to be doing to repro it? It seems to be working fine when I build/pack from Visual Studio.

[clairernovotny]

hmm...I just tried again and it's not repro'ing for me right now. very odd given that it repro'd locally and on Azure DevOps.

[clairernovotny]

wait...I see something.

With the 2.2.101 SDK, I see the errors, even on Azure DevOps. When I try the 3.0.100-preview 2 SDK to build, I don't.

I'm guessing that we both have the 3.0.100 preview sdk as the default. Adding a global.json to pin the 2.2.100/101 sdk should cause it to repro locally.

[clairernovotny]

Moreso, it works with the 3.0 SDK but not the 2.2 SDK:

Build with 2.2.101, you see this:
https://dev.azure.com/onovotny/GitBuilds/_build/results?buildId=1606&view=results

If you open the nupkg in NuGet Package Explorer and double-click the dll, you'll see the embedded ppdb data showing the sourcelink. It's wrong there, pointing at local files.

Built with the 3.0.100-preview2 sdk, here, doing the same thing, the sourcelink works correctly:
https://dev.azure.com/onovotny/GitBuilds/_build/results?buildId=1607&view=results

[bording]

I'm guessing that we both have the 3.0.100 preview sdk as the default.

I actually don't have a 3.0 SDK installed on this machine. I typically keep prerelease stuff on a VM instead.

The only SDKs I have installed are 2.1.503 and 2.2.102.

2.1.100/101 includes the 2.2.0 runtime, but 2.1.102 has the 2.2.1 runtime. I wonder if there was a bug fixed that could be relevant?

Can you try bumping up to 2.1.102 and see if that fixes things for you as well?