Skip to content

Upgrade Newtonsoft.Json repo from 13.0.1 to 13.0.3 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

mthalman
Copy link
Member

@mthalman mthalman marked this pull request as draft August 15, 2023 13:53
@mthalman
Copy link
Member Author

Converting this to draft while I work through the build issues.

@mthalman
Copy link
Member Author

mthalman commented Aug 17, 2023

I consolidated all the patch files into one. This was necessary because I needed to make an additional patch but that was conflicting due to overlap with other patches. So consolidating things made it easier to understand and cleaner.

The change I made was to disable EnablePackageValidation. This is needed because the API compat validation was running into errors like this:

/repos/source-build-externals/.dotnet/sdk/8.0.100-preview.7.23376.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error PKV006: Target framework .NETFramework,Version=v2.0 is no longer supported in the latest version. [/repos/source-build-externals/artifacts/source-build/self/src/src/newtonsoft-json/Src/Newtonsoft.Json/Newtonsoft.Json.csproj]

The reason for that is:

@mthalman mthalman marked this pull request as ready for review August 17, 2023 19:18
@mthalman mthalman requested a review from mmitche August 17, 2023 19:19
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please checkout the impact of this flowing into installer. I suspect this will pass because 13.0.1 will get picked up from n-1 artifacts. We should proactively add it to SBRP if that is the case.

@mthalman mthalman merged commit ca7c730 into dotnet:main Aug 17, 2023
@mthalman mthalman deleted the newtonsoft branch August 17, 2023 19:48
mthalman added a commit to mthalman/source-build-externals that referenced this pull request Aug 18, 2023
@mthalman mthalman restored the newtonsoft branch August 22, 2023 21:01
@mthalman mthalman deleted the newtonsoft branch August 29, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants