Fix solution parsing in dotnet test for Microsoft.Testing.Platform #51411

Youssef1313 · 2025-10-22T15:55:02Z

Youssef1313 · 2025-10-31T17:41:09Z

src/Cli/dotnet/Commands/Test/MTP/MSBuildUtility.cs

-        var msbuildArgs = MSBuildArgs.AnalyzeMSBuildArguments(buildOptions.MSBuildArgs, CommonOptions.PropertiesOption, CommonOptions.RestorePropertiesOption, CommonOptions.MSBuildTargetOption(), CommonOptions.VerbosityOption());
+        if (string.IsNullOrEmpty(activeSolutionConfiguration))
+        {
+            activeSolutionConfiguration = solutionFile.GetDefaultConfigurationName();


@rainersigwald @baronfel Can this be null or empty under any scenario?

unsure, would need to reach out to the VS Solution team for clarification on specific behaviors.

From comment from Richard below:

A valid solution file will always have at least one solution configuration and solution platform, it should be safe to not continue if this isn't true.

Youssef1313 · 2025-10-31T17:41:46Z

src/Cli/dotnet/Commands/Test/MTP/MSBuildUtility.cs

+            activeSolutionPlatform = solutionFile.GetDefaultPlatformName();
+        }
+
+        var solutionConfiguration = solutionFile.SolutionConfigurations.FirstOrDefault(c => c.ConfigurationName == activeSolutionConfiguration && c.PlatformName == activeSolutionPlatform)


@rainersigwald @baronfel Is this the right way to get the solution configuration?

I think you may need to handle the case where the solution configuration accepts any platform? but am not certain, again a question for the VS Solution team about required solution behaviors.

Platform and configuration are case insensitive, so if they are coming from the user's command line, these checks should ignore case.

A valid solution file will always have at least one solution configuration and solution platform, it should be safe to not continue if this isn't true.

I fixed to use OrdinalIgnoreCase comparison.

Youssef1313 · 2025-10-31T17:43:21Z

src/Cli/dotnet/Commands/Test/MTP/MSBuildUtility.cs

+        var solutionConfiguration = solutionFile.SolutionConfigurations.FirstOrDefault(c => c.ConfigurationName == activeSolutionConfiguration && c.PlatformName == activeSolutionPlatform)
+            ?? throw new InvalidOperationException($"The solution configuration '{activeSolutionConfiguration}|{activeSolutionPlatform}' is invalid.");
+
+        // TODO: What to do if the given key doesn't exist in the ProjectConfigurations?


@rainersigwald @baronfel Few lines below, I'm filtering projects only where the project configurations contains the requested solution configuration. Should that be an error instead if the solution configuration isn't found in the dictionary? or is it a valid scenario? And if valid scenario, is skipping the project the right behavior?

Youssef1313 · 2025-10-31T17:44:31Z

src/Cli/dotnet/Commands/Test/MTP/MSBuildUtility.cs

        using var collection = new ProjectCollection(globalProperties: CommonRunHelpers.GetGlobalPropertiesFromArgs(msbuildArgs), logger is null ? null : [logger], toolsetDefinitionLocations: ToolsetDefinitionLocations.Default);
        var evaluationContext = EvaluationContext.Create(EvaluationContext.SharingPolicy.Shared);
-        IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModules> projects = SolutionAndProjectUtility.GetProjectProperties(projectFilePath, collection, evaluationContext, buildOptions);
+        IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModules> projects = SolutionAndProjectUtility.GetProjectProperties(projectFilePath, collection, evaluationContext, buildOptions, configuration: null, platform: null);


In this code path we are dealing with a single project.

Youssef1313 · 2025-10-31T17:47:00Z

src/Cli/dotnet/Commands/Test/MTP/MSBuildUtility.cs

+        globalProperties.TryGetValue("Configuration", out var activeSolutionConfiguration);
+        globalProperties.TryGetValue("Platform", out var activeSolutionPlatform);


I think Configuration/Platform here are "solution configuration". This maps then to "project configuration" on the individual project files.

Should we clear out those values from the dictionary at this point?

This is a good line of thinking, I think you may be right. To do it right you'd use this to find the solutionconfiguration, and then use the solutionconfiguration to find per-project configuration/platform/etc arguments as we talked about today.

Youssef1313 · 2025-10-31T17:48:05Z

src/Cli/dotnet/Commands/Test/MTP/MSBuildUtility.cs

+            .Where(p => ProjectShouldBuild(solutionFile, p.RelativePath) && p.ProjectConfigurations.ContainsKey(solutionConfiguration.FullName))
+            .Select(p => (p.ProjectConfigurations[solutionConfiguration.FullName], p.AbsolutePath))
+            .Where(p => p.Item1.IncludeInBuild)
+            .Select(p => (p.AbsolutePath, p.Item1.ConfigurationName, p.Item1.PlatformName));


@rainersigwald @baronfel Can ConfigurationName or PlatformName here be null or empty?

unsure, to me these are all questions about solution behavior - and such the VS Solution team needs to eb brought in.

Valid projects require a configuration name, but platform is options. For example, reporting projects and setup projects don't have platforms. Also, there are many invalid solution files out there were configurations may be missing from the file. What to do in those cases is up to the tool, but it should probably be ignored, but not skip other valid projects.

Youssef1313 · 2025-11-03T13:14:59Z

@copilot Please add tests for #51481 and #51398. The tests should be in GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions, and test assets go in test/TestAssets/TestProjects.

Copilot · 2025-11-03T13:15:09Z

@Youssef1313 I've opened a new pull request, #51526, to work on those changes. Once the pull request is ready, I'll request review from you.

…guration support (#51526) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Youssef1313 <[email protected]>

Youssef1313 · 2025-11-16T23:00:21Z

@copilot Fix this failure:

Expected string "C:\h\w\AC400931\t\dotnetSdkTests\1hijiz2p.5kp\e56198d1-1eca---9A84D171\MultiTestProjectSolutionWithSharedProject.slnx : error MSB4025: The project file could not be loaded. Microsoft.Build.Exceptions.InvalidProjectFileException: Solution filter file at "C:\h\w\AC400931\t\dotnetSdkTests\1hijiz2p.5kp\e56198d1-1eca---9A84D171\TestProjectsWithShared.slnf" includes project "TestProject/TestProject.csproj" that is not in the solution file at "C:\h\w\AC400931\t\dotnetSdkTests\1hijiz2p.5kp\e56198d1-1eca---9A84D171\MultiTestProjectSolutionWithSharedProject.slnx".  C:\h\w\AC400931\t\dotnetSdkTests\1hijiz2p.5kp\e56198d1-1eca---9A84D171\TestProject\TestProject.csproj
C:\h\w\AC400931\t\dotnetSdkTests\1hijiz2p.5kp\e56198d1-1eca---9A84D171\MultiTestProjectSolutionWithSharedProject.slnx : error MSB4025:    at Microsoft.Build.Shared.ProjectFileErrorUtilities.VerifyThrowInvalidProjectFile(Boolean condition, String errorSubCategoryResourceName, BuildEventFileInfo projectFile, Exception innerException, String resourceName, Object[] args)
C:\h\w\AC400931\t\dotnetSdkTests\1hijiz2p.5kp\e56198d1-1eca---9A84D171\MultiTestProjectSolutionWithSharedProject.slnx : error MSB4025:    at Microsoft.Build.Construction.SolutionFile.ValidateProjectsInSolutionFilter()
C:\h\w\AC400931\t\dotnetSdkTests\1hijiz2p.5kp\e56198d1-1eca---9A84D171\MultiTestProjectSolutionWithSharedProject.slnx : error MSB4025:    at Microsoft.Build.Construction.SolutionFile.ReadSolutionModel(SolutionModel solutionModel)
C:\h\w\AC400931\t\dotnetSdkTests\1hijiz2p.5kp\e56198d1-1eca---9A84D171\MultiTestProjectSolutionWithSharedProject.slnx : error MSB4025:    at Microsoft.Build.Construction.SolutionFile.ParseUsingNewParser()" to contain "TestProject.dll".

Copilot · 2025-11-16T23:00:29Z

@Youssef1313 I've opened a new pull request, #51770, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Youssef1313 <[email protected]>

Youssef1313 · 2025-11-18T15:03:54Z

/backport to release/10.0.1xx

github-actions · 2025-11-18T15:04:06Z

Started backporting to release/10.0.1xx (link to workflow run)

github-actions · 2025-11-18T15:04:34Z

@Youssef1313 backporting to release/10.0.1xx failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

Youssef1313 added 4 commits October 22, 2025 17:48

Fix solution parsing in dotnet test for Microsoft.Testing.Platform

e763d34

Add ProjectShouldBuild

7a3920a

Hack

6ef9d54

Add comment

304b212

Youssef1313 marked this pull request as ready for review October 23, 2025 12:53

Youssef1313 requested review from YuliiaKovalova, baronfel, mariam-abdulla, nohwnd and rainersigwald October 23, 2025 12:54

mariam-abdulla approved these changes Oct 23, 2025

View reviewed changes

Youssef1313 added 2 commits October 31, 2025 18:37

A bit of progress

b58730f

Fix

8b11323

Youssef1313 commented Oct 31, 2025

View reviewed changes

Copilot AI mentioned this pull request Nov 3, 2025

Add tests for solution filter with shared projects and platform configuration support #51526

Merged

richardstanton approved these changes Nov 3, 2025

View reviewed changes

Merge branch 'release/10.0.2xx' into dev/ygerges/parse-sln

cdb835d

build-analysis bot mentioned this pull request Nov 11, 2025

GenerateBundle Task fails writing to singlefilehost.exe #50784

Open

Copilot AI and others added 2 commits November 12, 2025 11:18

Add tests for solution filter with shared projects and platform confi…

8a749af

…guration support (#51526) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Youssef1313 <[email protected]>

Ensure full path is passed to SolutionFile.Parse

c5f0cb1

This was referenced Nov 12, 2025

Tests Failing in Template Engine: Failed to update search cache. (The SSL connection could not be established, see inner exception.) #51147

Open

SSL Template Issue Causes Missing OSX Templates #51198

Open

Template Engine SSL Connection Issue #51574

Open

build-analysis bot mentioned this pull request Nov 12, 2025

Known Test Repository Issue Sometimes Misses Test Failures dotnet/dnceng#6411

Open

3 tasks

Non buildable

f4d2700

Youssef1313 added 2 commits November 15, 2025 12:04

Update test

21a1db7

Fix test

af02344

Copilot AI mentioned this pull request Nov 16, 2025

Fix solution filter path separators for .slnx files on Windows #51770

Merged

Fix solution filter path separators for .slnx files on Windows (#51770)

b21d084

Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Youssef1313 <[email protected]>

Youssef1313 mentioned this pull request Nov 17, 2025

Project file falsy considererd as VSTest project instead of MSTest project microsoft/testfx#6948

Closed

Case sensitivity, nullability

e58f7ab

This was referenced Nov 18, 2025

Fix slnf path separator handling to support both Unix and Windows style paths dotnet/msbuild#12730

Merged

dotnet test --solution fails to resole path with backslash in solution filter on Linux #51521

Closed

Fix slnf test assets to use \\ #51791

Merged

Improve comments

58c5531

nohwnd approved these changes Nov 18, 2025

View reviewed changes

Youssef1313 enabled auto-merge (squash) November 18, 2025 10:57

Youssef1313 merged commit 0a0a993 into release/10.0.2xx Nov 18, 2025
22 of 25 checks passed

Youssef1313 deleted the dev/ygerges/parse-sln branch November 18, 2025 12:11

dotnet-maestro bot mentioned this pull request Nov 18, 2025

[release/10.0.2xx] Source code updates from dotnet/sdk dotnet/dotnet#3413

Merged

Youssef1313 mentioned this pull request Nov 18, 2025

[release/10.0.1xx] Fix solution parsing in dotnet test for Microsoft.Testing.Platform #51794

Merged

		globalProperties.TryGetValue("Configuration", out var activeSolutionConfiguration);
		globalProperties.TryGetValue("Platform", out var activeSolutionPlatform);

Fix solution parsing in dotnet test for Microsoft.Testing.Platform #51411

Fix solution parsing in dotnet test for Microsoft.Testing.Platform #51411

Uh oh!

Conversation

Youssef1313 commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Youssef1313 commented Nov 3, 2025

Uh oh!

Copilot AI commented Nov 3, 2025

Uh oh!

Youssef1313 commented Nov 16, 2025

Uh oh!

Copilot AI commented Nov 16, 2025

Uh oh!

Uh oh!

Youssef1313 commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Youssef1313 commented Oct 22, 2025 •

edited

Loading