[Hot Reload] Do not refresh browser until changes are applied #51210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
commented
Oct 11, 2025
|
@DustinCampbell ptal |
This was referenced Oct 12, 2025
DustinCampbell
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Browser sometimes does not display changed content after applying changes.
We send browser refresh message too early. The browser actually refreshed but sometimes it happened before the changes were applied on the server and thus the server responded with the old content.
Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3086, #51107
Customer Impact
Impacts Hot Reload scenarios for web app scenarios, including Aspire.
Customer may perceive Hot Reload as unreliable as the browser does not display applied changes.
Regression?
Risk
Justification: The impact is limited to sending Hot Reload messages to browser and the change is trivial.
Verification
Packaging changes reviewed?