[StaticWebAsset] Exclude source maps from updating fingerprinted blazor.js #49178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @@maraf. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a regression by updating the logic to exclude .map files from the fingerprinting process in Blazor during build and publish. The changes include:
- Adding a PropertyGroup to store JavaScript file names.
- Filtering and adjusting item groups to ensure only .js files are processed.
- Updating static web asset item names and references accordingly.
src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets
Outdated
Show resolved
Hide resolved
3 tasks
pavelsavara
reviewed
May 28, 2025
src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets
Show resolved
Hide resolved
…6_0.targets Co-authored-by: Copilot <[email protected]>
javiercn
approved these changes
May 29, 2025
pavelsavara
approved these changes
May 29, 2025
|
/ba-g Failures are not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #46988.
During build we fingerprint
.js, but the publish target expected to fingerprint all assets in_BlazorJSFile. Under some scenarios this collection also contains.js.mapfiles.This PR updates the logic to explicitly exclude
.mapfiles from the affected target logic.