Add dotnet-suggest to the skip list in JoinVerticalsAssetSelector.cs #48600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-suggest has a stable version number (in the SemVer sense) so we need to skip it for now.
ghost
added
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds "dotnet-suggest" to the list of assets to skip, based on its stable version number.
- Adds a new condition to exclude "dotnet-suggest"
- Keeps the asset exclusion consistent with similar assets
Comments suppressed due to low confidence (1)
src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/ManifestAssets/JoinVerticalsAssetSelector.cs:38
- [nitpick] Consider extracting the asset ID "dotnet-suggest" into a named constant for improved maintainability and consistency with other asset comparisons.
StringComparer.OrdinalIgnoreCase.Equals(assetVerticalMatch.AssetId, "dotnet-suggest") ||
mmitche
approved these changes
Apr 21, 2025
This was referenced Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet-suggest has a stable version number (in the SemVer sense) so we need to skip it for now.
Fixes dotnet/source-build#5060