Dispose open handle on the package #20136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
joperezr
reviewed
Aug 25, 2021
| Package package = CreatePackage(packageReader, runtimeGraph); | ||
| package.PackagePath = packagePath; | ||
| return package; | ||
| using (PackageArchiveReader packageReader = new PackageArchiveReader(packagePath)) |
There was a problem hiding this comment.
NIT: you could also just use the inline using since the scope is the variable scope anyway. Also, inside method CreatePackage we seem to be using a NuspecReader, is that disposable too? If so, does it get disposed by PackageArchiveReader.Dispose? If not we should add a using there as well.
There was a problem hiding this comment.
Also, inside method CreatePackage we seem to be using a NuspecReader, is that disposable too?
NuspecReader is not disposable. I will leave "using" as it for now (donot want to rekick the builds).
joperezr
approved these changes
Aug 25, 2021
|
/backport to release/6.0.1xx-rc1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dangling reference and we are hitting file contetnion issues because of this while trying to use this package in aspnet core repo
Tested locally and it no longer repros