Fix SuppressTrimAnalysisWarnings #17050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be set before the .NET SDK targets get imported, otherwise the .NET defaults win.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Can we add a test to ensure it doesn't regress again? |
|
https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmPublishTest.cs#L37 would be a good place to add one. |
pranavkm
approved these changes
Apr 20, 2021
eerhardt
approved these changes
Apr 20, 2021
pranavkm
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be set before the .NET SDK targets get imported, otherwise the .NET defaults win.
I was too hasty in #16865, and regressed this when I responded to @eerhardt's feedback. @pranavkm noticed that blazor was producing warnings after my change. I've now double-checked that this change doesn't produce warnings by default for blazor/web.