Skip to content

Fix asserts and GC holes with Unsafe.Subtract/ByteOffset #99019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 29, 2024
Merged

Fix asserts and GC holes with Unsafe.Subtract/ByteOffset #99019

merged 15 commits into from
Feb 29, 2024
+29 −4

Conversation

@MichalPetryka
Copy link
Contributor

Found in #99011.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 27, 2024
@ghost
Copy link

ghost commented Feb 27, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Found in #99011.

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

EgorBo
EgorBo reviewed Feb 27, 2024
View reviewed changes
@MichalPetryka MichalPetryka mentioned this pull request Feb 27, 2024
Merged
@teo-tsirpanis teo-tsirpanis added the community-contribution Indicates that the PR has been added by a community member label Feb 27, 2024
@MichalPetryka MichalPetryka changed the title Fix an assert with Unsafe.Subtract Fix asserts with Unsafe.Subtract/ByteOffset Feb 28, 2024
This was referenced Feb 28, 2024
Closed
Open
Closed
@EgorBo EgorBo self-requested a review February 28, 2024 10:18
@MichalPetryka MichalPetryka changed the title Fix asserts with Unsafe.Subtract/ByteOffset Fix asserts and GC holes with Unsafe.Subtract/ByteOffset Feb 28, 2024
MichalPetryka added a commit to MichalPetryka/runtime that referenced this pull request Feb 28, 2024
@MichalPetryka
Copy the NativeAOT AllocateTypeAssociatedMemory to Mono
f408cb4 
Found in dotnet#99019
@MichalPetryka MichalPetryka mentioned this pull request Feb 28, 2024
Merged
This was referenced Feb 28, 2024
Closed
Closed
vargaz pushed a commit that referenced this pull request Feb 29, 2024
@MichalPetryka
Copy the NativeAOT AllocateTypeAssociatedMemory to Mono (#99072)
5cd274b 
* Copy the NativeAOT AllocateTypeAssociatedMemory to Mono

Found in #99019

* Update RuntimeHelpersTests.cs

* Update RuntimeHelpers.Mono.cs

* Update RuntimeHelpers.Mono.cs
@build-analysis build-analysis bot mentioned this pull request Feb 29, 2024
Closed
EgorBo
EgorBo approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

EgorBo
EgorBo reviewed Feb 29, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Feb 29, 2024
Closed
@EgorBo EgorBo merged commit b72ec6c into dotnet:main Feb 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalPetryka @EgorBo @teo-tsirpanis