Skip to content

Conversation

@DoctorKrolic
Copy link
Contributor

This is required to use new language features like collection expressions e.g. in #96964

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-crossgen2-coreclr labels Jan 31, 2024
@ViktorHofer
Copy link
Member

I approved this but it's @jkoritzinsky who introduced these properties. Jeremy, PTAL.

Co-authored-by: Viktor Hofer <[email protected]>
@jkoritzinsky
Copy link
Member

We're going to need to update the sourcebuild baseline. Can you update this line to refer to 4.8?

<UsagePattern IdentityGlob="Microsoft.CodeAnalysis*/*4.7.*" />

@DoctorKrolic
Copy link
Contributor Author

I thought this would be easier... @jkoritzinsky PTAL

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkoritzinsky
Copy link
Member

Failures are all known.

@jkoritzinsky jkoritzinsky merged commit 7410954 into dotnet:main Jan 31, 2024
@DoctorKrolic DoctorKrolic deleted the update-code-analysis-version branch February 1, 2024 07:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants