Skip to content

Conversation

@radical
Copy link
Member

@radical radical commented Dec 15, 2023

IL-linked dlls get copied to the publish/ directory when using AOT. This is because in ProcessPublishFilesForWasm target the ResolvedFileToPublish item ends with a copy of the original .dll files, even though they should be replaced with what was received from the nested publish.

@ghost ghost added the area-Build-mono label Dec 15, 2023
@ghost ghost assigned radical Dec 15, 2023
IL-linked dlls get copied to the `publish/` directory when using AOT.
This is because in `ProcessPublishFilesForWasm` target the
`ResolvedFileToPublish` item ends with a copy of the original .dll
files, even though they should be replaced with what was received from
the nested publish.
@radical radical marked this pull request as ready for review December 19, 2023 01:24
@radical radical requested a review from lewing as a code owner December 19, 2023 01:24
@radical radical added the arch-wasm WebAssembly architecture label Dec 19, 2023
@ghost
Copy link

ghost commented Dec 19, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

IL-linked dlls get copied to the publish/ directory when using AOT. This is because in ProcessPublishFilesForWasm target the ResolvedFileToPublish item ends with a copy of the original .dll files, even though they should be replaced with what was received from the nested publish.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Build-mono

Milestone: -

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@radical radical merged commit d425183 into dotnet:main Dec 19, 2023
@radekdoulik
Copy link
Member

this improved the size a lot :-)

image

should it be back ported to NET8 or was the issue present only in the main?

@radical radical deleted the fix-blazor-publish branch January 4, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants