[wasm/wasi] Fix size regression #95992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blazor size regression was fixed by: ``` commit ec31705 Author: Ankit Jain <[email protected]> Date: Wed Dec 6 05:36:59 2023 -0500 [wasm] Fix regressed file sizes for blazor (dotnet#92664) ``` .. but a subsequent PR created close to that undid some of the changes: ``` commit a128c15 Author: Ankit Jain <[email protected]> Date: Mon Dec 11 15:45:58 2023 -0500 [wasm/wasi] Consolidate build targets (dotnet#95775) ``` Essentially, `-g` was being passed to the link, and compile-bc steps. Found in dotnet/perf-autofiling-issues#25891 .
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBlazor size regression was fixed by: .. but a subsequent PR created close to that undid some of the changes: Essentially, Found in dotnet/perf-autofiling-issues#25891 .
|
ghost
added
the
Member
Author
|
TODO:
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Dec 14, 2023
pavelsavara
approved these changes
Dec 14, 2023
Member
Author
|
Failing hybridGlobalization tests are #95983 . |
This was referenced Jan 3, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blazor size regression was fixed by:
.. but a subsequent PR created close to that undid some of the changes:
Essentially,
-gwas being passed to the link, and compile-bc steps.Blazor Release/AOT
Found in dotnet/perf-autofiling-issues#25891 .