Skip to content

[release/8.0-staging] Fix JsonArray.Add and ReplaceWith regressions. #94882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 22, 2023
Merged

[release/8.0-staging] Fix JsonArray.Add and ReplaceWith regressions. #94882

merged 8 commits into from
Nov 22, 2023

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 16, 2023 •
edited by eiriktsarpalis
Loading

Backport of #94854 to release/8.0-staging

/cc @eiriktsarpalis

Customer Impact

Fixes a customer-reported regression from .NET 7 when trying to add a JsonElement value to a JsonArray. See #94842 for more details.

Testing

Added relevant regression testing.

Risk

Low. Makes a relatively straightforward change to product code.

@ghost
Copy link

ghost commented Nov 16, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #94854 to release/8.0-staging

/cc @eiriktsarpalis

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@tarekgh
Copy link
Member

tarekgh commented Nov 16, 2023

@eiriktsarpalis please ensure the package authoring is done.

@eiriktsarpalis eiriktsarpalis self-assigned this Nov 17, 2023
@eiriktsarpalis eiriktsarpalis added this to the 8.0.x milestone Nov 17, 2023
@eiriktsarpalis eiriktsarpalis added the Servicing-consider Issue for next servicing release review label Nov 17, 2023
@build-analysis build-analysis bot mentioned this pull request Nov 17, 2023
Open
@eiriktsarpalis eiriktsarpalis added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 17, 2023
@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Nov 17, 2023

Approved over email.

@carlossanlop
Copy link
Contributor

carlossanlop commented Nov 17, 2023

I'm looking at the CI failures.

@carlossanlop carlossanlop modified the milestones: 8.0.x, 8.0.1 Nov 21, 2023
@carlossanlop
Fix the build error that was showing up after bumping the ServicingVe…
b00d045 
…rsion prop:

Assembly 'System.Text.Json.TestLibrary.Roslyn3.11' with identity 'System.Text.Json.TestLibrary.Roslyn3.11, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' uses 'System.Text.Json, Version=8.0.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' which has a higher version than referenced assembly 'System.Text.Json' with identity 'System.Text.Json, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
@carlossanlop
Copy link
Contributor

carlossanlop commented Nov 22, 2023

@ViktorHofer I think I found the root cause. Can you please review my commit? Code Complete for the Jan Release is tomorrow Wednesday so we need to get this merged ASAP.

@carlossanlop
Copy link
Contributor

carlossanlop commented Nov 22, 2023

The old error went away, but a new one showed up.

This was referenced Nov 22, 2023
Closed
Closed
carlossanlop
carlossanlop approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packaging error is fixed. The new CI failures are pre-existing and unrelated. This is good to merge. Thanks @ViktorHofer.

@carlossanlop carlossanlop merged commit a20ee6f into release/8.0-staging Nov 22, 2023
@carlossanlop carlossanlop deleted the backport/pr-94854-to-release/8.0-staging branch November 22, 2023 17:01
@ViktorHofer ViktorHofer mentioned this pull request Nov 27, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@tarekgh tarekgh tarekgh approved these changes

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eiriktsarpalis eiriktsarpalis

Labels

area-System.Text.Json Servicing-approved Approved for servicing release

Projects

None yet

Milestone

8.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@tarekgh @eiriktsarpalis @carlossanlop @ViktorHofer