Avoid extra console write for clearing on Unix #89026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-console Issue Details
|
This was referenced Jul 17, 2023
lewing
approved these changes
Jul 17, 2023
adamsitnik
reviewed
Jul 18, 2023
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
Thank you for the optimization @stephentoub. PTAL at my comment.
stephentoub
force-pushed
the
consoleclearwrite
branch
from
58c69a9 to
d61cea7
Compare
adamsitnik
approved these changes
Aug 4, 2023
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @stephentoub !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#88487 (comment)