Cleanup file descriptions baked into Windows unmanaged .dlls #77080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete Microsoft and .NET Framework from the descriptions
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
jkotas
commented
Oct 15, 2022
| @@ -1,4 +0,0 @@ | |||
| #define FX_VER_FILEDESCRIPTION_STR "Native data compression routines\0" | |||
jkotas
commented
Oct 15, 2022
| set(NATIVECOMPRESSION_SOURCES ${ZLIB_SOURCES} ${NATIVECOMPRESSION_SOURCES}) | ||
|
|
||
| if (GEN_SHARED_LIB) | ||
| add_definitions(-DVER_FILEDESCRIPTION_STR="System.IO.Compression.Native") |
Member
Author
There was a problem hiding this comment.
This matches what we use as file descriptions for managed System.*.dlls
|
Tagging subscribers to this area: @hoyosjs Issue DetailsDelete Microsoft and .NET Framework from the descriptions
|
danmoseley
approved these changes
Oct 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete Microsoft and .NET Framework from the descriptions