-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Remove usages of Ubuntu 16.04 from pipelines #75513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsUbuntu Xenial 16.04 has reached the end of its five year LTS window. Summary:
|
cc9bb3e to
bc4f125
Compare
df466a2 to
d693422
Compare
d693422 to
89a6456
Compare
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
...libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj
Show resolved
Hide resolved
| *crossbuild=true*) | ||
| crossBuild=1 | ||
| extraargs="$extraargs $1" | ||
| shift 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handled /p:CrossBuild=true this way to support multiple property cases like ./build.sh /p:'RuntimeFlavor=coreclr;CrossBuild=true;Configuration=release'. Ideally, all cross-building CI legs should explicitly pass -cross (which appends /p:CrossBuild=true), but an explicit /p:CrossBuild=true should have the same effect.
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
The latest binutils 2.39 linker turned out to be stricter than its predecessors: Generating native code
/usr/bin/aarch64-alpine-linux-musl-ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build)
/__w/1/s/artifacts/bin/coreclr/Linux.arm64.Debug/crossgen2/linux-musl-arm64/native/crossgen2
has a LOAD segment with RWX permissionsRefs:
We have couple of options:
@jkotas, which option do you suggest? (I think we must fix it or suppress it for consumers, regardless of the option selected for our CI leg, as consumer can have latest binutils in their PATH) |
|
It would be useful to figure out which segment it is complaining about. It should not be hard to fix. |
|
With Ideally we should find a way to |
We do the page protection flipping around GS cookie in nativeaot too, so it sounds like we will have a problem with Linux arm64 with 64kB pages. The page protection flipping around GS cookie seems very fragile. I am wondering whether we should stop doing that, in nativeaot at least. |
|
One problem is that we have hardcoded assumptions about page sizes: runtime/src/coreclr/nativeaot/Runtime/CommonMacros.h Lines 154 to 161 in cb6fb60
int getpagesize(void) from unistd.h). As it stands, 64K paged linux-arm64 kernels are currently not supported in NativeAOT regardless of the linker flavor.
System.Speech failures on Windows are unrelated (#75732). |
|
@dotnet/runtime-infrastructure Could you please review as well? |
|
CI failure is #75767. It's ready to merge. |
Ubuntu Xenial 16.04 has reached the end of its five year LTS window.
Summary:
linux-bionic.src/tests/Common/scripts, which don't work. The blob URLs in those scripts return 404 and all deleted scripts have replacements.