Make System.Net.Http.HPack.IntegerDecoder a struct
#54209
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsDescription
If it gets accepted, I will also file a corresponding PR on Customer ImpactAn allocation of 24/16 bytes per HTTP/2 or 3 connection, on 64/32-bit platforms. RegressionNo TestingN/A RiskThe risk is minimal; there is no behavior change. Future code should be careful to not store
|
teo-tsirpanis
force-pushed
the
integer-decoder-struct
branch
from
b808e5b to
6f0e226
Compare
|
I see some failures in QUIC tests. Are they related? |
scalablecory
changed the title
System.Net.Http.HPack.IntegerEncoder a structSystem.Net.Http.HPack.IntegerDecoder a struct
|
CI failures are unrelated. |
|
Oops, just saw that the commit message has the same typo in |
ghost
locked as resolved and limited conversation to collaborators
Description
System.Net.Http.HPack.IntegerDecoderis a mutable reference type containing two signed 32-bit integers. This PR makes it a struct, eliminating one small allocation per HTTP/2 or 3 connection and providing better locality. On 64-bit platforms the classes that useIntegerDecoderhave no size difference while on 32-bit ones they will gain four additional bytes.If it gets accepted, I will also file a corresponding PR on
aspnetcore.Customer Impact
An allocation of 24/16 bytes per HTTP/2 or 3 connection, on 64/32-bit platforms.
Regression
No
Testing
N/A
Risk
The risk is minimal; there is no behavior change. Future code should be careful to not store
IntegerDecoderon areadonlyfield; existing uses were updated.