Skip to content

Conversation

@ManickaP
Copy link
Member

@ManickaP ManickaP commented Apr 14, 2021

Follow up for: #50613

I updated the readme.md to reflect that we don't use STUB_TLS anymore and set the revision to the current main.

No code change, only docs.

cc: @wfurt

@ghost ghost added the area-System.Net label Apr 14, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow up for: #50613

I updated the readme.md to reflect that we don't use STUB_TLS anymore and set the revision to the current main.

cc: @wfurt

Author: ManickaP
Assignees: -
Labels:

area-System.Net

Milestone: -

@ManickaP ManickaP requested review from a team and CarnaViire April 14, 2021 13:00
@CarnaViire
Copy link
Member

After updating to this new version of MsQuic, I see two test failures:

  1. This one I've mentioned in my PR:
       System.Net.Quic.Tests.QuicConnectionTests_MsQuicProvider.AcceptStream_ConnectionAborted_ByClient_Throws [FAIL]
        Assert.Throws() Failure
        Expected: typeof(System.Net.Quic.QuicConnectionAbortedException)
        Actual:   typeof(System.Net.Quic.QuicOperationAbortedException): Operation aborted.
  1. This one is new:
      System.Net.Quic.Tests.MsQuicTests.CloseAsync_ByServer_AcceptThrows [FAIL]
        System.Net.Quic.QuicException : Connection has been shutdown by transport. Error Code: USER_CANCELED

I propose to put them under ActiveIssue here, and I'll add the new one to the test issue.

@ManickaP Are they failing on Linux too, or not?

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
if the failures are related to TLS I can take a look next week.
I suspect thay may be more related to other msquick changes.

@ManickaP
Copy link
Member Author

  • CloseAsync_ByServer_AcceptThrows fails for me too, although I'd swear it didn't yesterday.
  • AcceptStream_ConnectionAborted_ByClient_Throws passes.

I'll add [ActiveIssue] for CloseAsync_ByServer_AcceptThrows.

@ManickaP ManickaP mentioned this pull request Apr 15, 2021
9 tasks
@ManickaP
Copy link
Member Author

I updated the test failing for me and sneaked in a comment typo fix.

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ManickaP ManickaP merged commit e7c7ba6 into dotnet:main Apr 15, 2021
@ManickaP ManickaP deleted the mapichov/msquic_update branch April 15, 2021 11:13
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants