Fix compilation errors if host does not support AVX2 #50316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Contributor
Author
|
Whom I can ping, so it can be looked into? I have old laptop at home, where I intend to play with NativeAOT. @hoyosjs can you take a look? |
Member
|
Pinvoke tests - @AaronRobinsonMSFT maybe |
AaronRobinsonMSFT
approved these changes
Apr 18, 2021
src/tests/Interop/PInvoke/Generics/GenericsNative.Vector256B.cpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@tannergooding can I ask you to take a look at this PR? |
src/tests/Interop/PInvoke/Generics/GenericsNative.Vector256U.cpp
Outdated
Show resolved
Hide resolved
it actually pass -march=native, otherwise AVX2 would not be enabled.
kant2002
force-pushed
the
kant/issue-50175
branch
from
d400aed to
b5bebba
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50175