Skip to content

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jan 4, 2021

Part of #46429

This PR produces a NuGet package containing the MonoAOTCompiler task and imports the MonoAOTCompiler task for immediate use.

Steve Pfister and others added 4 commits January 4, 2021 12:46
Remove changes related to testing the MonoAOTCompiler NuPkg

Remove changes to deprecated files that led to file additions
@vargaz
Copy link
Contributor

vargaz commented Jan 4, 2021

Shouldn't all wasm build tasks be put into one nuget package ?

@mdh1418
Copy link
Member Author

mdh1418 commented Jan 4, 2021

@vargaz I thought MonoAOTCompiler could apply to iOS and Android as well

@steveisok
Copy link
Member

steveisok commented Jan 4, 2021

Shouldn't all wasm build tasks be put into one nuget package ?

This package is intended to be used beyond runtime. Each of the sdk's will define a workload that will contain a bunch of workload packs (the AOT MSBuild Task is one of them). That will allow the developer to choose (or not) to install different parts of the dotnet sdk.

I would prefer to have wasm specific tasks to be in their own package (should we need any).

@marek-safar marek-safar requested a review from radical January 5, 2021 17:32
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be very helpful to have an example project that uses this package. Or at least explain how this will get used. That would make it easier to think about where the UsingTask should be, for example.

@mdh1418
Copy link
Member Author

mdh1418 commented Jan 5, 2021

We use the MonoAOTCompiler task in the mono samples, just not as NuPkg imports. The main purpose of making the NuPkg is for external use, so those developing outside of dotnet/runtime can call the MonoAOTCompiler task. Such as how https://github.com/dotnet/samples/tree/master/core/mono-samples are using the respective NuPkgs. Where would be the best place to note that?

@radical
Copy link
Member

radical commented Jan 5, 2021

We use the MonoAOTCompiler task in the mono samples, just not as NuPkg imports. The main purpose of making the NuPkg is for external use, so those developing outside of dotnet/runtime can call the MonoAOTCompiler task. Such as how https://github.com/dotnet/samples/tree/master/core/mono-samples are using the respective NuPkgs. Where would be the best place to note that?

Maybe in a README.md next to the pkgproj.

Have you tried using the generated nuget with such a sample?

Co-authored-by: Ankit Jain <[email protected]>
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mdh1418 mdh1418 merged commit f6754ae into dotnet:master Jan 6, 2021
@mdh1418 mdh1418 deleted the mdhwang/add_monoaotcompiler_pkgproj branch January 6, 2021 20:43
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants