-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[mono] Add MonoAOTCompiler MSBuild Task to produce NuPkg #46537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Add MonoAOTCompiler MSBuild Task to produce NuPkg #46537
Conversation
Remove changes related to testing the MonoAOTCompiler NuPkg Remove changes to deprecated files that led to file additions
src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
|
Shouldn't all wasm build tasks be put into one nuget package ? |
|
@vargaz I thought MonoAOTCompiler could apply to iOS and Android as well |
This package is intended to be used beyond runtime. Each of the sdk's will define a workload that will contain a bunch of workload packs (the AOT MSBuild Task is one of them). That will allow the developer to choose (or not) to install different parts of the dotnet sdk. I would prefer to have wasm specific tasks to be in their own package (should we need any). |
src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
radical
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be very helpful to have an example project that uses this package. Or at least explain how this will get used. That would make it easier to think about where the UsingTask should be, for example.
...icrosoft.NET.Runtime.MonoAOTCompiler.Task/Microsoft.NET.Runtime.MonoAOTCompiler.Task.pkgproj
Outdated
Show resolved
Hide resolved
src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
|
We use the |
Maybe in a Have you tried using the generated nuget with such a sample? |
src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ankit Jain <[email protected]>
radical
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Part of #46429
This PR produces a NuGet package containing the MonoAOTCompiler task and imports the
MonoAOTCompilertask for immediate use.