Fix and reenable TestUserCredentialsPropertiesOnWindows

[adamsitnik]

Removal of the user via Interop.NetUserDel was never working because it was missing CharSet = CharSet.Unicode. I've fixed that and changed the test to:

• use more unique name than "test"
• always try to remove the test account first
• fail (don't swallow the exception) if the creation of the account failed
• fail (don't ignore error code NERR_UserNotFound) if the removal of the account failed

The user might have been missing rights to read and execute dotnet.exe (for example when build.cmd was executed from Admin PSW) and in that case the test was throwing Access denied from Process.Start. I've changed the test to always add the permission to read and execute before running the .exe

Now it works as expected:

Fixes #18978

[ghost]

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Removal of the user via Interop.NetUserDel was never working because it was missing CharSet = CharSet.Unicode. I've fixed that and changed the test to:
* use more unique name than "test"
* always try to remove the test account first
* fail (don't swallow the exception) if the creation of the account failed
* fail (don't ignore error code NERR_UserNotFound) if the removal of the account failed

The user might have been missing rights to read and execute dotnet.exe (for example when build.cmd was executed from Admin PSW) and in that case the test was throwing Access denied from Process.Start. I've changed the test to always add the permission to read and execute before running the .exe

Now it works as expected:

Author:	adamsitnik
Assignees:	-
Labels:	area-System.Diagnostics.Process
Milestone:	6.0.0

[eiriktsarpalis]

If CI is happy I'm happy.

[adamsitnik]

/azp run runtime-libraries outerloop

[azure-pipelines]

No pipelines are associated with this pull request.

[adamsitnik]

/azp list

[azure-pipelines]

CI/CD Pipelines for this repository:

• coreclr-gc-longrunning
• coreclr-gc-simulator
• runtime-coreclr outerloop
• runtime-coreclr jitstress
• runtime-coreclr jitstressregs
• runtime-coreclr jitstress2-jitstressregs
• runtime-coreclr r2r-extra
• runtime-coreclr r2r
• runtime-coreclr runincontext
• runtime-coreclr crossgen2
• runtime-libraries-coreclr outerloop
• runtime-libraries-coreclr outerloop-windows
• runtime-libraries-coreclr outerloop-linux
• runtime-libraries-coreclr outerloop-osx
• runtime
• runtime-libraries enterprise-linux
• runtime-libraries stress-http
• runtime-libraries stress-ssl
• runtime-live-build
• runtime-coreclr crossgen2 outerloop
• coreclr-release-outerloop-nightly
• sync-runtime-to-mono
• runtime-coreclr crossgen2-composite
• runtime-jit-experimental
• dotnet-linker-tests
• runtime-coreclr ilasm
• runtime-coreclr clrinterpreter
• runtime-coreclr crossgen2-composite gcstress
• runtime-libraries-mono outerloop
• runtime-staging

[adamsitnik]

/azp run runtime-libraries-coreclr outerloop-windows

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[adamsitnik]

We stopped hearing from agent NetCorePublic-Pool 1. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error

So here we go again

/azp run runtime-libraries-coreclr outerloop-windows

[adamsitnik]

/azp run runtime-libraries-coreclr outerloop-windows

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[adamsitnik]

The CI has failed with a very interesting error:

    System.Diagnostics.Tests.ProcessStartInfoTests.TestUserCredentialsPropertiesOnWindows [FAIL]
      System.DllNotFoundException : Unable to load DLL 'netapi32.dll' or one of its dependencies: The specified module could not be found. (0x8007007E)
      Stack Trace:
           at System.Diagnostics.Tests.Interop.NetUserDel(String servername, String username)
        /_/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs(360,0): at System.Diagnostics.Tests.ProcessStartInfoTests.TestUserCredentialsPropertiesOnWindows()

edit: because 'netapi32.dll' is not available on nano

[adamsitnik]

/azp run runtime-libraries-coreclr outerloop-windows

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[adamsitnik]

If CI is happy I'm happy

The CI is happy and so am I ;)