Skip to content

Updates the RID graph to include Android 30 #45442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steveisok merged 2 commits into from
Dec 2, 2020
Merged

Updates the RID graph to include Android 30 #45442

steveisok merged 2 commits into from
Dec 2, 2020

Conversation

@steveisok
Copy link
Member

@steveisok steveisok commented Dec 1, 2020

Fixes #45438

@steveisok steveisok requested a review from marek-safar December 1, 2020 22:30
@steveisok steveisok merged commit af6ed24 into master Dec 2, 2020
@steveisok steveisok deleted the add-android30-rid branch December 2, 2020 15:22
@jonathanpeppers jonathanpeppers mentioned this pull request Dec 10, 2020
Closed
jonathanpeppers added a commit to jonathanpeppers/runtime that referenced this pull request Dec 10, 2020
@jonathanpeppers
Use unix as the parent for the Android RID graph
d3a7329 
Fixes: dotnet/sdk#14908

In a .NET 6 Android project, adding a NuGet package such as:

    <PackageReference Include="akavache" Version="6.0.30"/>

...would include Linux native libraries from dependencies, such as:

    packages\sqlitepclraw.lib.e_sqlite3.linux\1.1.11\runtimes\linux-arm64\native\libe_sqlite3.so

Comparing the RID graph for iOS and Android in
`dotnet\sdk\*\RuntimeIdentifierGraph.json`:

    "ios": {
      "#import": [
        "unix"
      ]
    },
    ...
    "android": {
      "#import": [
        "linux"
      ]
    },

It seems like Android graph should match iOS here, as changing `linux`
-> `unix` solved this issue for me locally.

Based on the changes in dotnet#45442, I updated `runtimeGroups.props` to
specify `linux` instead of `unix` for Android. Then I ran this command
to update the checked-in `.json` files:

    > dotnet build .\src\libraries\pkg\Microsoft.NETCore.Platforms -p:UpdateRuntimeFiles=true
@jonathanpeppers jonathanpeppers mentioned this pull request Dec 10, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar marek-safar approved these changes

Assignees

No one assigned

Labels

area-Meta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update RID graph to include the latest Android version

4 participants

@steveisok @marek-safar @Dotnet-GitSync-Bot